Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolldown on_idle_hook & configurable dispute period #843

Merged
merged 24 commits into from
Nov 29, 2024

Conversation

mateuszaaa
Copy link
Member

@mateuszaaa mateuszaaa commented Nov 23, 2024

  • introduces configurable dispute periods per l1. Intial values can be provided in chain spec. And modified later on using dedicated extrinsic set_dispute_period (root only)
  • adds benchmarks for functions used in hooks, to simplify weight calculations
  • accounts for huge read/writes based on substrate diagram (2mb)
  • refactoring of the logic of updates scheduler/executed:
  • on_initialize_hook - schedules requests to be executed as well as moves execution counter to the next element in the queue if the previous one was already executed.
  • on_idle_hook - Executes some requests from current block based on available weight.

Behavior change:
Now update that is scheduled to be executed at block N may start being executed in the same block
Stops executing of given update as soon as maintanance mode is triggered https://mangatafinance.atlassian.net/browse/GASP-1632

@mateuszaaa mateuszaaa added full-benchmarks perform full benchmarking and archive results 🚀 deploy Deploy fungible environment and removed 🚀 deploy Deploy fungible environment labels Nov 25, 2024
@mateuszaaa mateuszaaa merged commit 0a07b8c into eth-rollup-develop Nov 29, 2024
2 checks passed
@mateuszaaa mateuszaaa deleted the feature/rolldown_on_idle_hook branch November 29, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-benchmarks perform full benchmarking and archive results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants